Skip to content

Add conditional check for calc-coverage job on forks - #258

Merged
e-perl-NOAA merged 2 commits into
mainfrom
calc-coverage-dont-run-forks
Jul 22, 2026
Merged

Add conditional check for calc-coverage job on forks#258
e-perl-NOAA merged 2 commits into
mainfrom
calc-coverage-dont-run-forks

Conversation

@e-perl-NOAA

Copy link
Copy Markdown
Contributor

Address @kellijohnson-NOAA's issue #257

@e-perl-NOAA
e-perl-NOAA requested a review from Bai-Li-NOAA July 21, 2026 13:26
@github-actions

Copy link
Copy Markdown

Code Metrics Report

Coverage Code to Test Ratio Test Execution Time
94.8% 1:0.8 7s

Reported by octocov

@e-perl-NOAA

Copy link
Copy Markdown
Contributor Author

This reusable workflow is not skipped when I called it from this branch is this PR.

@kellijohnson-NOAA

Copy link
Copy Markdown
Collaborator

The workflow shouldn't be skipped, just the portion of the workflow that tries to upload anything.

@e-perl-NOAA

Copy link
Copy Markdown
Contributor Author

OHHHHH, okay I see. Clearly not fully awake this morning ☕

@e-perl-NOAA

Copy link
Copy Markdown
Contributor Author

Not the best example because it the actual calculating of coverage fails, but it does have it skipping the upload step

@Bai-Li-NOAA Bai-Li-NOAA left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@e-perl-NOAA
e-perl-NOAA merged commit 7487657 into main Jul 22, 2026
12 checks passed
@e-perl-NOAA
e-perl-NOAA deleted the calc-coverage-dont-run-forks branch July 22, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants