Don't overwrite BUILD.bazel while making a release - #5376
Open
jwnimmer-tri wants to merge 1 commit into
Open
Conversation
Author
|
@Vertexwahn could you take a look? |
Vertexwahn
reviewed
Aug 12, 2026
Vertexwahn
approved these changes
Aug 12, 2026
Contributor
|
@jwnimmer-tri LGTM - only the env variables |
Instead, add automation to 'develop' to ensure that it's always kept up to date. Add missing header file 'logic.hpp'. Re-apply e509007 "Remove alwayslink=True Bazel flag", which was accidentally reverted previously by the broken update script. Signed-off-by: Jeremy Nimmer <jeremy.nimmer@tri.global>
jwnimmer-tri
force-pushed
the
build-file-maintenance
branch
from
August 12, 2026 13:17
560518e to
e2b8828
Compare
Author
|
Thanks! Fixed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead, add automation to 'develop' to ensure that it's always kept up to date.
Add missing header file 'logic.hpp'.
Re-apply e509007 "Remove alwayslink=True Bazel flag", which was accidentally reverted previously by the broken update script.