Skip to content

Databasing update: Remove all .csv-related functionality - #144

Closed
BvB93 wants to merge 19 commits into
masterfrom
devel
Closed

Databasing update: Remove all .csv-related functionality#144
BvB93 wants to merge 19 commits into
masterfrom
devel

Conversation

@BvB93

@BvB93 BvB93 commented Jul 7, 2020

Copy link
Copy Markdown
Member

See nlesc-nano/data-CAT#42:

  • Removes the .csv file as a component of the database; everything is now handled via the .hdf5 format.

@BvB93 BvB93 added the enhancement New feature or request label Jul 7, 2020
@BvB93 BvB93 added this to the CAT 0.10.0 milestone Jul 7, 2020
@BvB93 BvB93 self-assigned this Jul 7, 2020
@BvB93
BvB93 marked this pull request as draft July 7, 2020 15:27
@codecov

codecov Bot commented Jul 14, 2020

Copy link
Copy Markdown

Codecov Report

Merging #144 into master will decrease coverage by 0.21%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
- Coverage   65.14%   64.93%   -0.22%     
==========================================
  Files          45       45              
  Lines        3552     3513      -39     
  Branches      598      595       -3     
==========================================
- Hits         2314     2281      -33     
+ Misses       1091     1086       -5     
+ Partials      147      146       -1     
Impacted Files Coverage Δ
CAT/workflows/key_map.py 100.00% <ø> (ø)
CAT/workflows/workflow_dicts.py 77.14% <0.00%> (ø)
CAT/attachment/qd_opt.py 30.76% <18.18%> (-1.15%) ⬇️
CAT/attachment/perp_surface.py 58.46% <47.36%> (+2.40%) ⬆️
CAT/attachment/edge_distance.py 73.07% <60.00%> (+1.37%) ⬆️
CAT/attachment/ligand_attach.py 69.79% <63.33%> (-1.86%) ⬇️
CAT/workflows/workflow.py 75.59% <70.96%> (-0.58%) ⬇️
CAT/attachment/ligand_opt.py 82.67% <90.00%> (-0.18%) ⬇️
CAT/attachment/distribution.py 91.26% <90.90%> (ø)
CAT/__version__.py 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c24ddb3...b39c9df. Read the comment docs.

@BvB93
BvB93 marked this pull request as ready for review July 14, 2020 14:51
@BvB93 BvB93 removed this from the CAT 0.10.0 milestone Nov 18, 2021
@BvB93
BvB93 marked this pull request as draft November 18, 2021 15:37
@BvB93 BvB93 closed this Aug 31, 2022
@BvB93
BvB93 deleted the devel branch August 31, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant