fix: detect existing AgriSoilExtended by id, not by type query - #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ingest worker detected an existing AgriSoilExtended entity via queryEntities(type=AgriSoilExtended) filtered by id. But the reader uses the platform @context Link, which expands the type to the canonical URI (nkz-os/sdm-proposals) — while the stored entity may be under the default-context URI. This false-zero makes the existence check fail, falling through to create_entity which 409s (id already exists).
Fix: replace the type-query existence check with a type-agnostic get_entity(id) call. The wrapper already exposes get_entity (returns None on 404). This is robust regardless of stored type URI.