Make L2 exchange response ordering deterministic - #325
Draft
California-a wants to merge 1 commit into
Draft
Conversation
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The default Rust HashMap and HashSet use randomized seeds and expose arbitrary iteration order. Both L2 exchange models emitted responses while iterating those containers. When several fills had the same timestamp, identical inputs could therefore append responses in different orders across processes.
OrderBus intentionally preserves append order for equal timestamps, so the randomized traversal became externally observable and could change downstream order-lifecycle handling.
Using BTreeMap and BTreeSet gives the response path a stable ascending OrderId order without changing the public API.
Validation