Skip to content

Add accept4 on DragonFly, Emscripten, Fuchsia, Illumos, and NetBSD.#1654

Merged
bors[bot] merged 1 commit into
nix-rust:masterfrom
rtzoeller:accept4
Feb 6, 2022
Merged

Add accept4 on DragonFly, Emscripten, Fuchsia, Illumos, and NetBSD.#1654
bors[bot] merged 1 commit into
nix-rust:masterfrom
rtzoeller:accept4

Conversation

@rtzoeller

Copy link
Copy Markdown
Collaborator

Expand accept4 support to more platforms.

@rtzoeller

Copy link
Copy Markdown
Collaborator Author

bors r+

bors Bot added a commit that referenced this pull request Feb 3, 2022
1654: Add accept4 on DragonFly, Emscripten, Fuchsia, Illumos, and NetBSD. r=rtzoeller a=rtzoeller

Expand accept4 support to more platforms.

Co-authored-by: Ryan Zoeller <rtzoeller@rtzoeller.com>
@bors

bors Bot commented Feb 3, 2022

Copy link
Copy Markdown
Contributor

Timed out.

@asomers asomers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors retry

bors Bot added a commit that referenced this pull request Feb 5, 2022
1654: Add accept4 on DragonFly, Emscripten, Fuchsia, Illumos, and NetBSD. r=rtzoeller a=rtzoeller

Expand accept4 support to more platforms.

Co-authored-by: Ryan Zoeller <rtzoeller@rtzoeller.com>
@asomers

asomers commented Feb 5, 2022

Copy link
Copy Markdown
Member

@rtzoeller I think bors is failing because there's no successful build for ""Linux armv7 uclibceabihf", which is in master's bors.toml but not this branch's. But this branch's .cirrus.yml is the one that is getting built. So perhaps rebasing would fix it?

@rtzoeller

Copy link
Copy Markdown
Collaborator Author

@rtzoeller I think bors is failing because there's no successful build for ""Linux armv7 uclibceabihf", which is in master's bors.toml but not this branch's. But this branch's .cirrus.yml is the one that is getting built. So perhaps rebasing would fix it?

I'll give that a shot in a few hours when I get home. Thanks!

@bors

bors Bot commented Feb 5, 2022

Copy link
Copy Markdown
Contributor

Canceled.

@rtzoeller

Copy link
Copy Markdown
Collaborator Author

bors retry

bors Bot added a commit that referenced this pull request Feb 5, 2022
1654: Add accept4 on DragonFly, Emscripten, Fuchsia, Illumos, and NetBSD. r=rtzoeller a=rtzoeller

Expand accept4 support to more platforms.

Co-authored-by: Ryan Zoeller <rtzoeller@rtzoeller.com>
@rtzoeller

Copy link
Copy Markdown
Collaborator Author

Hmm, @asomers it looks like bors is still having issues even after the rebase. All the jobs are stuck in "Running" and none are linked to any builds.

Did #1603 get something wrong?

@asomers

asomers commented Feb 5, 2022

Copy link
Copy Markdown
Member

I don't see anything wrong in that PR. It looks to me like it might be a bors problem. See https://app.bors.tech/batches/193727 . It doesn't think that any builds have finished yet.

@rtzoeller

Copy link
Copy Markdown
Collaborator Author

@asomers did bors' permissions/connection to access nix-rust/nix get reset somehow? I.e. at https://github.com/apps/bors

@asomers

asomers commented Feb 5, 2022

Copy link
Copy Markdown
Member

No, the configuration looks correct to me.

@rtzoeller

Copy link
Copy Markdown
Collaborator Author

@notriddle do you have any insight into what could be happening here? We're seeing bors show all jobs as running (e.g. in https://app.bors.tech/batches/193727), but none ever completing, leading to attempts timing out.

Thanks!

@asomers

asomers commented Feb 5, 2022

Copy link
Copy Markdown
Member

I opened a thread on the bors forum. If we can't get any help for a couple of days, I think we'll just have to start using the old-fashioned merge button. https://forum.bors.tech/t/bors-not-getting-build-notifications-for-nix-rust-nix/632

@bors

bors Bot commented Feb 5, 2022

Copy link
Copy Markdown
Contributor

Timed out.

@notriddle

Copy link
Copy Markdown
Contributor

bors r=rtzoeller

@bors

bors Bot commented Feb 5, 2022

Copy link
Copy Markdown
Contributor

🔒 Permission denied

Existing reviewers: click here to make notriddle a reviewer

@notriddle

Copy link
Copy Markdown
Contributor

bors r=rtzoeller

bors Bot added a commit that referenced this pull request Feb 5, 2022
1654: Add accept4 on DragonFly, Emscripten, Fuchsia, Illumos, and NetBSD. r=rtzoeller a=rtzoeller

Expand accept4 support to more platforms.

Co-authored-by: Ryan Zoeller <rtzoeller@rtzoeller.com>
@notriddle

Copy link
Copy Markdown
Contributor

I poked around through the API, but this really looks like a CI problem, and not a bors problem.

@rtzoeller

Copy link
Copy Markdown
Collaborator Author

Thanks for the investigation @notriddle!

And indeed, https://cirrus-ci.com/build/4744058793885696 shows the following error text:

Builds for public repositories initialized by applications are not supported.

I found cirruslabs/cirrus-ci-docs#972 which is reporting the same error, but with no resolution.

@bors

bors Bot commented Feb 5, 2022

Copy link
Copy Markdown
Contributor

Timed out.

@asomers

asomers commented Feb 6, 2022

Copy link
Copy Markdown
Member

Fedor Korotkov said it's fixed. Let's find out.

bors retry

@bors bors Bot merged commit 0bd56d9 into nix-rust:master Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants