refactor(konsole): streamline the module#635
Open
bmrips wants to merge 3 commits into
Open
Conversation
- Remove `profiles.*.font.name` null checks since this is already caught by the option type. - Remove redundant `lib.mkMerge`s. - Set the `profiles.<name>.name` option default to `<name>`. - Use the submodule to merge `profiles.*.extraConfig` with settings derived from `profiles.*.(colorScheme|command|font|name)`. - Rename `profiles.*.extraConfig` to `profiles.*.settings` to match the typical naming of RFC42-style options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR streamlines the Konsole module:
profiles.*.font.namenull checks since this is already caught by the option type.lib.mkMerges.profiles.<name>.nameoption default to<name>.profiles.*.extraConfigwith settings derived fromprofiles.*.(colorScheme|command|font|name).profiles.*.extraConfigtoprofiles.*.settingsto match the typical naming of RFC42-style options.While at it, I also did two small treewide refactorings:
inherits.attrsOfplaceholder texts.Backwards Compatibility
To the best of my knowledge, these changes are backwards-compatible with one exception.
Merging
profiles.*.settingswith the otherprofiles.*options may result into conflicting definitions ifprofiles.*.settingscontains definitions that are derived from the other options, e.g.General.Name, which requires the user to explicitly override those. However, I personally prefer explicit overrides to implicit overrides.Testing
I successfully build my own configuration against these changes.