shortcuts: do not escape commas in service shortcuts#555
Open
bmrips wants to merge 1 commit into
Open
Conversation
bmrips
force-pushed
the
fix-commas-in-shortcuts
branch
from
44bdbdf to
72eb949
Compare
bmrips
force-pushed
the
fix-commas-in-shortcuts
branch
from
72eb949 to
72a0a02
Compare
Contributor
Author
|
The pipeline now fails despite not failing before, so it is presumably already broken on |
bmrips
force-pushed
the
fix-commas-in-shortcuts
branch
4 times, most recently
from
27d8478 to
72539a5
Compare
Contributor
Author
|
This PR is a descendant of #634. |
bmrips
force-pushed
the
fix-commas-in-shortcuts
branch
2 times, most recently
from
357f9f6 to
4118dd5
Compare
bmrips
force-pushed
the
fix-commas-in-shortcuts
branch
from
4118dd5 to
1e9b6a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, commas in the keys of shortcuts are escaped:
However, Plasma does not pick up the
foo.desktoplaunch shortcut since it is malformed. By setting the shortcut through the UI, I found out that commas do not have to be escaped for shortcuts that are grouped under the[services]section, i.e. the corrected example would beThis PR fixes this bug.
Tests
I successfully tested this change on my own system.