make-disk-image: Fix overriding kernel modules#1277
Open
AlexLov wants to merge 2 commits into
Open
Conversation
After [#530764](NixOS/nixpkgs#530764) PR kernel modules should be passed as `kernelModules` instead of `kernel`. Fixes error: ``` … while evaluating definitions from `/nix/store/1c1jbpjisa2249vrffd97vmjdflbcprx-source/lib/make-disk-image.nix': (stack trace truncated; use '--show-trace' to show the full, detailed trace) error: vmTools: the `kernel` argument (kernel-modules) has no `target` attribute, so the kernel image filename cannot be determined. If you are passing a module tree (e.g. from `pkgs.aggregateModules`) to make extra modules available, pass it via `kernelModules` instead and keep `kernel` pointing at a real kernel derivation. Alternatively, pass `kernelImage` explicitly with the path of the bootable image relative to the `kernel` derivation output (e.g. "bzImage" or "Image"). ``` This should also fixes tests in [nix-community#1273](nix-community#1273) PR
Diffumist
suggested changes
Jul 9, 2026
Co-authored-by: Diffumist <git@diffumist.me>
Diffumist
approved these changes
Jul 10, 2026
JuneStepp
added a commit
to JuneStepp/disko
that referenced
this pull request
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #530764 PR kernel modules should be passed as
kernelModulesinstead ofkernel.Fixes error:
This should also fixes tests in #1273 PR