fix: unlock once per bcachefs filesystem#1265
Open
amaanq wants to merge 1 commit into
Open
Conversation
Encrypted bcachefs filesystems can have several mountpoints, but we only need to unlock the filesystem once. Unlocking inside each mount fragment can hit `EBUSY` after the first mount has already opened the device. This commit moves the unlock step to the filesystem-level mount setup so it runs once before mounting the root and subvolumes, while keeping the existing already-unlocked check.
8976c1b to
e2bc980
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encrypted bcachefs filesystems can have several mountpoints, but we only
need to unlock the filesystem once. Unlocking inside each mount fragment
can hit
EBUSYafter the first mount has already opened the device.This commit moves the unlock step to the filesystem-level mount setup
so it runs once before mounting the root and subvolumes, while keeping
the existing already-unlocked check.