nixos-test-driver-manual: add#331
Conversation
|
ping @cyntheticfox is there anything i can/shall do above having the CI green? |
|
ping @cyntheticfox what can i do to help getting this in? |
|
ping @cyntheticfox i have seen that other things have been merged inbetween. Is there anything that i can do to make this PR acceptable? |
cyntheticfox
left a comment
cyntheticfox
left a comment
There was a problem hiding this comment.
Sorry, I typically go top-to-bottom in terms of PRs
Taking a look at this entry, I feel that it should be far clearer that this project isn't just "opinionated", but unofficial, though it looks to provide some very good examples 🙂
Additionally, it isn't a bad idea to link back to and improve the official docs, rather than just the underlying Nix code.
In general, I think the "manual" could use another "does this sentence make remotely any sense in context" review of both the comment flyouts (why?) and the main text (feels kinda LLM-y IMO)
|
@cyntheticfox: updated and pushed the changes. About the guide style: I wrote this completely by hand (of course i used LLMs to improve the mkdocs configuration, generate the social media cards for links, etc. etc. etc.). As the maintainer of the test driver, I actually wrote big parts of the official docs too. The guide links to the official docs on purpose so I don't repeat the same text twice. Many people have thanked me for this guide, so I was surprised by your feedback. This PR has been open for 3 months while newer ones were merged. If you don't want this guide in your awesome list, that is totally fine. But instead of arguing about impressions, let’s save time. If you have specific, constructive changes, I am happy to fix them. Otherwise, please just close the PR - you have all right to do that, but be open and fair about it please. |
2 participants
No description provided.