Skip to content

Add NüschtOS Modules#245

Open
SuperSandro2000 wants to merge 1 commit into
nix-community:mainfrom
SuperSandro2000:patch-2
Open

Add NüschtOS Modules#245
SuperSandro2000 wants to merge 1 commit into
nix-community:mainfrom
SuperSandro2000:patch-2

Conversation

@SuperSandro2000

Copy link
Copy Markdown
Member

Notable things which I should really write down:

@cyntheticfox cyntheticfox left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it is the repository description, the entry feels a little too vague next to the other entries.

Adding some of those features like "with extra LDAP integration and easy pgsql upgrades" would do way more to distinguish the project from the other entries and from most NixOS modules and configurations.

I won't suggest those exact words though -- you can probably find better descriptors of what makes it different

@SuperSandro2000

Copy link
Copy Markdown
Member Author

Took me a while but the readme should now be way more polished and we also integrated our options search into it. Can you take another look?

@cyntheticfox

Copy link
Copy Markdown
Member

Er, I think my review wasnt very clear; the repo and project are good. The awesome-nix description text proposed in this PR is just vague -- it mentions having configurations and being opinionated, but doesn't say anything about the "what" the modules are, though that is in the PR description.

That'd be adding on to the text to make it something like

...Opinionated, LDAP-integrated, and shared-service NixOS modules.

or something like that to make it more specific

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants