You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
add a two-slot flock capacity helper shared with parrot-to-klv
gate each normal job on one slot and the image publisher on both
keep fork PRs hosted and preserve the pinned CI image
This makes the occasional cross-repository overlap safe while allowing parrot-to-klv's build and sanitizer jobs to run concurrently. See parrot-to-klv#108.
Validation
bash -n ci/with-capacity.sh
two one-slot jobs run concurrently
a two-slot holder blocks a one-slot job until release
Reviewed alongside parrot-to-klv#109; the main review is posted there. Two
findings belong on this side. Nothing blocking.
I exercised ci/with-capacity.sh rather than reading it: two 1-slot holders run
concurrently, a third waits for a release, a 2-slot holder waits for both and
excludes others, and an invalid slot count exits 2 cleanly. Setting CI_CAPACITY_DIR for the native publisher is a good catch — without it mkdir -p /ci-capacity would fail for the runner user on the host.
1. Low-medium — cross-repository image coupling has no guard. parrot-to-klv
now pins an image built from this repository's ci/Dockerfile and relies on it
carrying pkg-config and the gstreamer -dev packages. If that dependency list
is ever trimmed, parrot's CI breaks and nothing here signals it: the dependency
is real but invisible from the producing side. A comment in ci/Dockerfile
naming parrot as a consumer would cost one line.
2. Low — the 2-slot publisher can be overtaken. It holds slot-0 while
blocking on slot-1, and flock gives no ordering guarantee, so a 1-slot job
that arrives later can acquire first. I reproduced one overtake directly. Under a
stream of eight 1-slot jobs the publisher still got through after roughly two, so
this is bounded rather than a hang — worth a comment near the blocking flock
rather than a fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flockcapacity helper shared with parrot-to-klvThis makes the occasional cross-repository overlap safe while allowing parrot-to-klv's build and sanitizer jobs to run concurrently. See parrot-to-klv#108.
Validation
bash -n ci/with-capacity.shgit diff --checkCloses #67.
Author: Codex (model: openai/gpt-5)