fix(runtime): match route rules on canonical path#4396
Draft
pi0 wants to merge 6 commits into
Draft
Conversation
A request like `/app/admin%2fpanel` keeps `%2f` opaque in `event.url.pathname` (h3 `decodeURI`s the path but leaves `/`/`\` reserved), so route-rule matching never saw a literal `admin` segment: a narrow `basicAuth` rule on `/app/admin/**` was skipped while a broader proxy rule on `/app/**` still forwarded the request. Downstreams that decode `%2f` back to `/` (Apache, PHP, most CDNs) then served the protected resource with no credentials. Match route rules on a canonical path that additionally decodes `%2f`/`%5c` and resolves `.`/`..` segments, so an auth rule matches whenever the served path would. This mirrors nginx ($uri decoded for location matching, $request_uri raw for proxy_pass) — proxy/redirect targets keep forwarding the raw path. Canonicalization uses string ops (mirroring h3's internal resolveDotSegments) rather than `new URL`, which would re-encode characters h3 already decoded (spaces, non-ASCII) and desync matching from `event.url.pathname`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
pi0
changed the title
`event.url.pathname` is not `decodeURI`-d; srvx FastURL keeps percent-encodings opaque (only literal `.`/`..` and `\` are WHATWG-resolved). Fix the inaccurate comments and the unit test that fed already-decoded inputs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.