feat/dark mode : Added shadcn dark mode to dashboard#852
Conversation
|
Thank you for the PR @aloktomarr Can you try testing with a running project that contains all the resources? There are some missing spots. For example: Go into I'll review what you can done so far. |
|
Hi David, Thank you for taking the time to review the PR. I have added the missing classes to the components, which should resolve the issues with dark mode. Please have a look and let me know if any further changes are needed. Thanks! |
Hi Alok, Thanks for the update! I appreciate you adding the missing classes to resolve some of the dark mode issues. I took a look at the changes, and I have a few suggestions to further align things with our design goals:
If you think it would help, I can submit a PR with these changes. Let me know what you think, or if you'd prefer to handle it yourself. Thanks again for your work on this! |
- Align dark mode CSS variables with the Nitric docs palette (background, foreground, muted, accent, popover, border, card, ring).- Keep the brand blue as the dark-mode primary color instead of the invalid HSL-as-rgb value (rendered wrong).- Make section headings (h1-h6) light in dark mode instead of near-black.- Add a dark background for the html element.- Move the theme toggle to the right of the Help button.- Add dark-mode variants to the shared Tabs component (API Explorer tabs and selected items). Light mode classes are left unchanged.
|
Hi David, First off, my sincere apologies for the very long silence on this I stepped away and it sat untouched for about a year. Thanks for your patience, and for the detailed, thoughtful review. I've now gone back through all your points and pushed an update:
Thanks again, and sorry once more for the delay! |



What does this PR do?
This PR adds dark mode support to the dashboard using shadcn/ui theme variables and next-themes for theme management.
Fixes #763
###Type of change
feature
Changes
Screenshots
[Add before/after screenshots showing light and dark modes]
Testing Done
Notes