Skip to content

Add offloading options to vmnet-run #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nirs merged 1 commit into from
Apr 1, 2026
Merged

Add offloading options to vmnet-run #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,6 @@ def main():
if args.start_address or args.end_address or args.subnet_mask:
p.error("--operation-mode required when using address options")

if args.connection == "runner":
if args.enable_offloading:
p.error("--enable-offloading not supported with --connection=runner")

signal.signal(signal.SIGTERM, terminate)
signal.signal(signal.SIGINT, terminate)

Expand Down
21 changes: 21 additions & 0 deletions run.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ struct client_options {
char *subnet_mask;
char *shared_interface;
char *network_name;
bool enable_tso;
bool enable_checksum_offload;
bool enable_isolation;

// Client options.
Expand Down Expand Up @@ -61,6 +63,8 @@ enum {
OPT_START_ADDRESS,
OPT_END_ADDRESS,
OPT_SUBNET_MASK,
OPT_ENABLE_TSO,
OPT_ENABLE_CHECKSUM_OFFLOAD,
OPT_ENABLE_ISOLATION,
OPT_NETWORK,
OPT_UNPRIVILEGED,
Expand All @@ -77,6 +81,8 @@ static struct option long_options[] = {
{"start-address", required_argument, 0, OPT_START_ADDRESS},
{"end-address", required_argument, 0, OPT_END_ADDRESS},
{"subnet-mask", required_argument, 0, OPT_SUBNET_MASK},
{"enable-tso", no_argument, 0, OPT_ENABLE_TSO},
{"enable-checksum-offload", no_argument, 0, OPT_ENABLE_CHECKSUM_OFFLOAD},
{"enable-isolation", no_argument, 0, OPT_ENABLE_ISOLATION},
{"network", required_argument, 0, OPT_NETWORK},
{"verbose", no_argument, 0, 'v'},
Expand All @@ -96,6 +102,7 @@ static void usage(int code)
" vmnet-run [--interface-id UUID] [--operation-mode shared|bridged|host]\n"
" [--start-address ADDR] [--end-address ADDR]\n"
" [--subnet-mask MASK] [--shared-interface NAME]\n"
" [--enable-tso] [--enable-checksum-offload]\n"
" [--enable-isolation] [--network NAME] [--unprivileged]\n"
" [-v|--verbose] [--version] [-h|--help]\n"
" -- command ...\n"
Expand Down Expand Up @@ -169,6 +176,14 @@ static void build_helper_argv(void)
append_helper_arg(options.shared_interface);
}

if (options.enable_tso) {
append_helper_arg("--enable-tso");
}

if (options.enable_checksum_offload) {
append_helper_arg("--enable-checksum-offload");
}

if (options.enable_isolation) {
append_helper_arg("--enable-isolation");
}
Expand Down Expand Up @@ -268,6 +283,12 @@ static void parse_options(int argc, char **argv)
validate_address(optarg, optname);
options.subnet_mask = optarg;
break;
case OPT_ENABLE_TSO:
options.enable_tso = true;
break;
case OPT_ENABLE_CHECKSUM_OFFLOAD:
options.enable_checksum_offload = true;
break;
case OPT_ENABLE_ISOLATION:
options.enable_isolation = true;
break;
Expand Down
2 changes: 2 additions & 0 deletions vmnet/vm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,8 @@ def runner_command(self, vm_command):
cmd.append(f"--shared-interface={self.args.shared_interface}")
elif self.args.operation_mode == "host" and self.args.enable_isolation:
cmd.append("--enable-isolation")
if self.enable_offloading:
cmd.extend(["--enable-tso", "--enable-checksum-offload"])
if self.args.verbose:
cmd.append("--verbose")
if not self.args.privileged:
Expand Down