Skip to content

fix: Use rigid affine initialization for BOLD mask - #1064

Merged
effigies merged 5 commits into
nipreps:maint/1.14.xfrom
effigies:fix/rigid-ai
Oct 2, 2026
Merged

effigies merged 5 commits into
nipreps:maint/1.14.xfrom
effigies:fix/rigid-ai

Conversation

@effigies

@effigies effigies commented Oct 2, 2026

Copy link
Copy Markdown
Member

This may address #1000. This fix was identified by @lobennett.

The affine initialization can afford to be rigid because the follow-up registration is affine:

{
"winsorize_upper_quantile": 0.98,
"winsorize_lower_quantile": 0.05,
"metric": ["Mattes"],
"metric_weight": [1],
"radius_or_number_of_bins": [64],
"transforms": ["Affine"],
"transform_parameters": [[0.1]],
"number_of_iterations": [[200]],
"convergence_window_size": [10],
"convergence_threshold": [1e-09],
"sampling_strategy": ["Random", "Random"],
"smoothing_sigmas": [[2]],
"sigma_units": ["mm", "mm", "mm"],
"shrink_factors": [[2]],
"sampling_percentage": [0.2],
"use_histogram_matching": [true]
}

I'm seeing if we can still make a PR against the old LTS branch.

effigies and others added 5 commits October 2, 2026 10:04
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "uvx codespell -w niworkflows",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@codecov

codecov Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.90%. Comparing base (000931d) to head (0ed972d).
⚠️ Report is 10 commits behind head on maint/1.14.x.

Additional details and impacted files
@@               Coverage Diff                @@
##           maint/1.14.x    #1064      +/-   ##
================================================
- Coverage         71.57%   70.90%   -0.68%     
================================================
  Files                89       89              
  Lines              8665     8571      -94     
  Branches           1079      935     -144     
================================================
- Hits               6202     6077     -125     
- Misses             2231     2263      +32     
+ Partials            232      231       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@effigies
effigies merged commit bafeb8a into nipreps:maint/1.14.x Oct 2, 2026
13 checks passed
@effigies
effigies deleted the fix/rigid-ai branch October 2, 2026 15:32
effigies added a commit that referenced this pull request Oct 2, 2026
1.14.5 (October 02, 2026)

Patch release in the 1.14.x series.

* FIX: Collect data interactions with sessions and bids filters (#1063)
* FIX: Write NIfTI data in the byte order the header declares (#1061)
* FIX: Drop bids_filters entries with no matching query (#1058)
* FIX: Disable colorbar after default switch (#1057)
* FIX: Use rigid affine initialization for BOLD mask (#1064)
effigies added a commit that referenced this pull request Oct 2, 2026
1.15.3 (October 02, 2026)

Patch release in the 1.15.x series.

* FIX: Use rigid affine initialization for BOLD mask (#1064)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant