Skip to content

Drop the dead num_threads input from MCFLIRT2ITK - #1060

Merged
effigies merged 1 commit into
nipreps:masterfrom
asaraog:fix/drop-dead-num-threads
Sep 17, 2026
Merged

effigies merged 1 commit into
nipreps:masterfrom
asaraog:fix/drop-dead-num-threads

Conversation

@asaraog

@asaraog asaraog commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Closes #1042. Nipype sets num_threads on any interface that declares it, so the deprecation warning always fired; MCFLIRT2ITK never used the value.

@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.15%. Comparing base (09d0d2b) to head (0a0609c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1060   +/-   ##
=======================================
  Coverage   67.14%   67.15%           
=======================================
  Files          54       54           
  Lines        6855     6850    -5     
  Branches      853      852    -1     
=======================================
- Hits         4603     4600    -3     
+ Misses       2038     2037    -1     
+ Partials      214      213    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@effigies

Copy link
Copy Markdown
Member

Seems right.

@effigies
effigies merged commit 72c134c into nipreps:master Sep 17, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning "Multithreading is deprecated. Remove the num_threads input"

2 participants