Repository navigation
Space-separate workflow descriptions in visit_desc - #1059
Merged
Merged
Conversation
collect_data merged every filter with queries[acq].update(entities), so a filter naming a suffix absent from a caller-supplied queries dict raised KeyError instead of being ignored. Closes nipreps#862
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1059 +/- ##
==========================================
+ Coverage 67.12% 67.18% +0.06%
==========================================
Files 54 54
Lines 6853 6848 -5
Branches 852 849 -3
==========================================
+ Hits 4600 4601 +1
+ Misses 2038 2034 -4
+ Partials 215 213 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mgxd
reviewed
Sep 14, 2026
mgxd
left a comment
mgxd
left a comment
Contributor
There was a problem hiding this comment.
Thanks! A few initial thoughts:
strip()feels too aggressive, as devs may want to separate workflow descriptions by multiple lines, i.e. (functional processing ... \n\n)- The collect data changes shouldn't be in this PR - please remove them
Contributor
Author
|
Thanks @mgxd! Both addressed: descriptions are no longer stripped (a space is added only where neither side has whitespace, so "\n\n" separators survive, with a test), and the collect_data changes are removed. |
mgxd
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #999. visit_desc joins descriptions with a space and strips them, so a description no longer needs a trailing space to stay separated.