Repository navigation
Drop bids_filters entries with no matching query - #1058
Merged
effigies merged 1 commit intoSep 8, 2026
Merged
Conversation
collect_data merged every filter with queries[acq].update(entities), so a filter naming a suffix absent from a caller-supplied queries dict raised KeyError instead of being ignored. Closes nipreps#862
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1058 +/- ##
==========================================
+ Coverage 67.12% 67.14% +0.02%
==========================================
Files 54 54
Lines 6853 6855 +2
Branches 852 853 +1
==========================================
+ Hits 4600 4603 +3
Misses 2038 2038
+ Partials 215 214 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
effigies
added
the
backport candidate
effigies
pushed a commit
that referenced
this pull request
Sep 28, 2026
collect_data merged every filter with queries[acq].update(entities), so a filter naming a suffix absent from a caller-supplied queries dict raised KeyError instead of being ignored. Closes #862
effigies
pushed a commit
that referenced
this pull request
Oct 2, 2026
collect_data merged every filter with queries[acq].update(entities), so a filter naming a suffix absent from a caller-supplied queries dict raised KeyError instead of being ignored. Closes #862
effigies
added a commit
that referenced
this pull request
Oct 2, 2026
1.14.5 (October 02, 2026) Patch release in the 1.14.x series. * FIX: Collect data interactions with sessions and bids filters (#1063) * FIX: Write NIfTI data in the byte order the header declares (#1061) * FIX: Drop bids_filters entries with no matching query (#1058) * FIX: Disable colorbar after default switch (#1057) * FIX: Use rigid affine initialization for BOLD mask (#1064)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #862.
collect_datamerges filters withqueries[acq].update(entities)and never checks thatacqis a key, so a filter naming a suffix absent from a caller-suppliedqueriesraises instead of being ignored:Two-line guard skips those filters. Test added using
generate_bids_skeleton; it fails without the fix with the sameKeyError.pytest niworkflows/utils: 73 passed, 5 skipped.