FIX: No BOLD images found for participant - #51
Open
Hyedryn wants to merge 1 commit into
Open
Conversation
|
Thanks for opening this pull request! It looks like this is your first time contributing to fMRIPrep. 😄 "name": "Contributor, New FMRIPrep",
"affiliation": "Department of fMRI prep'ing, Open Science Made-Up University",
"orcid": "<your id>"
}, ```
Of course, if you want to opt-out this time there is no problem at all with adding your name later. You will be always welcome to add it in the future whenever you feel it should be listed. |
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a fix for #50
Changes proposed in this pull request
Currently fmriprep-rodents consider that the collect_data function of niworkflows has the following header:
def collect_data( bids_dir, participant_label, task=None, echo=None, bids_validate=True, bids_filters=None, )Indeed, when calling collect_data, the task and echo parameters are not defined explicitly:
subject_data = collect_data( config.execution.layout, subject_id, config.execution.task_id, config.execution.echo_idx, bids_filters=config.execution.bids_filters, )[0]However, the header of the collect_data function of niworkflows has the optional parameter session_id before the optional parameter task.
def collect_data( bids_dir, participant_label, session_id=Query.OPTIONAL, task=None, echo=None, bids_validate=True, bids_filters=None, )When calling collect_data, the task and echo parameters should thus be defined explicitly:
subject_data = collect_data( config.execution.layout, subject_id, task=config.execution.task_id, echo=config.execution.echo_idx, bids_filters=config.execution.bids_filters, )[0]