ci: node 24 actions and workflow hardening - #10
Merged
Conversation
The very first run annotated that actions/checkout@v4 and actions/setup-python@v5 are node 20 actions: github forces node 24 on 2026-06-16 and removes node 20 from runners 2026-09-16. Bump to the node 24 majors (checkout@v5, setup-python@v6) before the four-day fuse burns down. Plus the two one-line hardening items from review: - persist-credentials: false — no later step needs git credentials, so don't leave the token in .git/config while pip build hooks and the test suite execute - concurrency group with cancel-in-progress — superseded runs on the same ref are cancelled instead of burning runner minutes No build/test step changes: triggers, commands, and order still match the CLAUDE.md CI/CD section exactly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #9. The very first CI run annotated that
actions/checkout@v4andactions/setup-python@v5are Node 20 actions — GitHub forces Node 24 on 2026-06-16 (four days out) and removes Node 20 from runners 2026-09-16. This bumps both to their Node 24 majors and applies the two one-line hardening items from the pre-merge review:actions/checkout@v5+actions/setup-python@v6(Node 24-ready)persist-credentials: false— no later step needs git credentials, so the token doesn't sit in.git/configwhile pip build hooks and the test suite executeconcurrencygroup withcancel-in-progress— superseded runs on the same ref get cancelled instead of burning runner minutesNo build/test step changes: triggers, commands, and order still match the CLAUDE.md CI/CD section exactly.
Test plan
pull_requestrun exercises the bumped actions end-to-end (checkout, python 3.11 + pip cache, full suite + ruff)