nimsuggest: move library code into suggest

[bung87]

Summary

Extract procedures that do not rely on the command-line from the
nimsuggest module to the suggest module.

Details

Changes:

• procedure findNode was moved and renamed to findTrackedNode
• procedure symFromInfo was moved and renamed to findTrackedSym
• the ide command execution part of executeNoHooks was extracted and
  moved into executeCmd

This makes the suggest module more of a reusable component for other
non-nimsuggest tools, e.g. the LSP server.

[saem]

@bung87 does this block #879? If so, can you note blockers/dependencies like that in the Notes for Reviewers section, thanks.

[bung87]

updated.

[saem]

I've done a quick read, but it looks like there was a move plus renames of 2 procedures and the extraction of another procedure.

Were there any other changes that I didn't spot? The extraction of the execueCmd procedure is a highlight that should be covered in the PR description.

[saem]

I spotted a few things, but I really like the idea of separating these things out, so we have a general core suggest module and then wrap it with nimsuggest or lsp specific modules to specialize it.

I can help with the PR phrasing, I just need you to provide the core content (what and why).

[bung87]

updated

[saem]

updated

Yup, I just need a some time to clean-up the PR message. In the meantime, if you can take another attempt at it based on the recent PR messages I've cleaned up, that'll save me some time, thanks.

[saem]

@bung87 have a read through the PR title + body

[saem]

/merge

[github-actions]

Merge requested by: @saem

Contents after the first section break of the PR description has been removed and preserved below:

---

Notes for Reviewers

this block #879, as I want rebase and
make cleaner commits.