Conversation
- parameter passing - typed ast construction
also rename/relocate tests to more appropriate location
- use blocks to document each test - reorder and group tests more logically - note tests that should work with `knownIssue` comments
- sketch of all missing tests identified thus far - plan for test coverage - inventory of existing tests - document questions and answers for future and current direction This will be used to create the initial test spec for varargs.
- relatively fine grained split of knownIssues for easier fixing - cross-reference knownIssues between parent and knownIssue tests - remove corresponding sketch tests from `tvarargs` - disable `tvarargs` so the `lang_callable/varags` category can be run
remove corresponding tests from tvarargs.
until it's fixed going to be marking lots of tests as known issue
- ensure varargs parameter is inferrable - add tests to disallow type parameter being set to varargs
Collaborator
Author
|
One of the things blocking this PR is that the core matchesAux loop needs to work on a per formal parameter basis instead of per argument as it is now. This allows for the progress of matching against formals to be controlled more precisely. As part of that I believe one of the things that needs to happen is to move default parameter handling/setting to happen in |
saem
force-pushed
the
saem-spec-specify-varargs
branch
from
September 27, 2025 17:39
4447e88 to
5808ef6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
varargparameters and to a lesser extent the pragmaDetails
Notes for Reviewers
sigmatchin one gotvarargsmanual.rst) to indicate new behaviour and future directionsigmatch.matchesAuxwhich contains the parameter handling- [ ] any related updates/changes