Skip to content

Plan #126: Add review comment author blacklist - #127

Closed
nil4u wants to merge 1 commit into
developfrom
126-mr-pipeline-comment-comment-review-build-resume-task/plan
Closed

Plan #126: Add review comment author blacklist#127
nil4u wants to merge 1 commit into
developfrom
126-mr-pipeline-comment-comment-review-build-resume-task/plan

Conversation

@nil4u

@nil4u nil4u commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Source issue

#126 — 不同团队在 MR pipeline 中的评论作者黑名单,阻止命中评论触发 review/build 等 resume task。

Plan file

.issue-flow/issues/126-mr-pipeline-comment-comment-review-build-resume-task/plan/001-implementation.md

Summary

  • .issue-flow/config.jsonagentrix.reviewCommentAuthorBlacklist 中配置作者身份数组。
  • 在统一 review-comment dispatch 入口使用 provider 已归一化作者做大小写不敏感的完整匹配。
  • 命中时在所有 acknowledge、task lock 和 resume 副作用前返回可诊断的跳过结果。
  • 补充配置、GitHub/GitLab、边界与防 resume 测试,并更新管理员文档;不改变 review::off 语义。

Review focus

  • 配置字段位置、兼容性、空配置和无效项处理是否符合仓库约定。
  • 过滤是否使用归一化作者而非评论正文或 provider bot 类型,并覆盖 GitHub/GitLab 字段差异。
  • 黑名单判断是否早于所有副作用,且未命中与既有 review-comment/resume 流程保持一致。
  • 测试、文档和验收标准是否覆盖作者缺失、大小写/格式边界、重复事件及 review::off 回归。

@nil4u nil4u added the mr-by::plan PR or MR was created by the plan action label Sep 1, 2026 — with agentrix-ai
@nil4u nil4u closed this Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mr-by::plan PR or MR was created by the plan action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant