v3.4.3: fix Requires PHP mismatch, disclose third-party services, drop non-commercial geo API - #7
Merged
miyanialkesh7 merged 1 commit intoAug 21, 2026
Conversation
…es, drop non-commercial geo API - Fix Requires PHP: readme.txt said 7.3 (left over from a botched merge conflict resolution) while composer.json says >=8.0; both now say 8.0. - Add Requires at least / Requires PHP to the plugin's own header, not just readme.txt, so WP core's compatibility checks see them directly. - Consolidate IP geolocation onto a single cached HTTPS call to ipwho.is (country, country code, timezone). Removes calls to ip-api.com, whose free tier prohibits commercial use -- a conflict with this plugin's advertised WooCommerce support -- and which was requested over plain HTTP. - Add a Third-Party Services section to readme.txt disclosing ipwho.is, ipify, and flagcdn.com. - Bump Tested up to 7.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Requires PHP: 7.3(left over from an unresolved merge-conflict marker that got committed, then "fixed" to the wrong side in a follow-up commit) whilecomposer.jsonrequires>=8.0. Both now say 8.0.Requires at least: 6.3/Requires PHP: 8.0to the plugin's own header (online-active-users.php), not just readme.txt, so WP core's own compatibility gate sees them.ip-api.com: its free tier explicitly prohibits commercial use, which conflicts with this plugin's advertised WooCommerce support, and the calls were also made over plain HTTP. Country, country code, and timezone are now all resolved from a single cached HTTPS call toipwho.is(already used for country) — fewer external requests, one commercially-permitted HTTPS provider instead of two mixed providers.== Third-Party Services ==section to readme.txt disclosing ipwho.is, ipify, and flagcdn.com, per WordPress.org policy.Tested up to: 7.1.WPOAU_VERSION,phpstan-bootstrap.php,Stable tag), with changelog/upgrade-notice entries.Verification
phpcs --standard=phpcs.xml.dist(WordPress-Extra + WordPress-Docs + PHPCompatibilityWP): 0 errorscomposer compat(PHPCompatibilityWP, testVersion 8.0-): 0 errorsphpstan analyse: 0 errorsphpunit(incl.VersionConsistencyTest, which checksVersion:==Stable tag:and text domain match): passingTest plan