chore: update package.json, + fixed npm run build issue on Windows - #6
Open
colindekker wants to merge 1 commit into
Open
chore: update package.json, + fixed npm run build issue on Windows#6colindekker wants to merge 1 commit into
colindekker wants to merge 1 commit into
Conversation
…sue on windows (l)
Owner
|
Thanks for the pull request. It looks like the upgrade to Enzyme needs to set an adaptor to react 16. I'm in the process of upgrading one of my other libraries to react 16 and the jest and enzyme upgrades aren't backwards compatible so I had to fix a few of my tests to use the new API. If that is more work than you intended to take on perhaps we should rescope this PR to be for making the library compatible with Windows. I did a quick search on it and supposedly "&&" isn't completely cross-platform either so perhaps we should use a library like, npm-run-all something similar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for, allowing for eact 16. fixed npm script issue on windows (npm run build did not understand ;, repalced with && )