fix: prevent mouse packets leaking into remote shells#3
Open
moneycaringcoder wants to merge 1 commit into
Open
fix: prevent mouse packets leaking into remote shells#3moneycaringcoder wants to merge 1 commit into
moneycaringcoder wants to merge 1 commit into
Conversation
moneycaringcoder
force-pushed
the
fix/mouse-click-passthrough
branch
from
July 10, 2026 13:57
049e896 to
14986d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
terminal.scroll, including Shift/Alt/Ctrl modifiers and source ordering with keyboard inputmouse_click_passthroughconfiguration for mouse-aware remote TUIsFixes #2
Behavior
mouse_click_passthroughdefaults tofalse, preventing clicks, releases, drags, and motion from becoming shell input. Set it globally or under[hosts.<name>]to restore raw non-wheel mouse forwarding for a host running mouse-aware TUIs. Wheel scrolling remains semantic in either mode.Why configuration
An earlier implementation inferred remote mouse mode by scanning frames, but upstream intentionally left that gate out in 34ba4f6. Terminal frames are normalized and may not contain the remote application's original DECSET/DECRST sequence, so this change avoids reviving that heuristic. Explicit passthrough keeps the behavior deterministic until Herdr exposes mouse mode through the terminal-session API.
Test plan
cargo test— 41 passedcargo clippy --all-targets— passed with the same four warnings present on upstreammaincargo build --release