Skip to content

debug the remove elements. #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
henrydewaziers wants to merge 1 commit into
base: master
Choose a base branch
from
Open

debug the remove elements. #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions feedback.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,25 @@ var log = function( msg ) {
},
// function to remove elements, input as arrays
removeElements = function( remove ) {
for (var i = 0, len = remove.length; i < len; i++ ) {
var item = Array.prototype.pop.call( remove );
if ( item !== undefined ) {
if (item.parentNode !== null ) { // check that the item was actually added to DOM
item.parentNode.removeChild( item );
if (!Array.isArray(remove)) {
Array.prototype.forEach.call(
remove,
function (index, item) {
if (item !== undefined) {
if (item.parentNode !== undefined) {
item.parentNode.removeChild(item);
}
}
}
);
return;
}

var item;
for (; item = Array.prototype.pop.call(remove);) {
if (item !== undefined) {
if (item.parentNode !== null) { // check that the item was actually added to DOM
item.parentNode.removeChild(item);
}
}
}
Expand Down