Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1109
Description
Extends the
shouldPrintRawValueandrawValueattribute handling introduced forScalar\Int_in #1127 toScalar\Float_.When
shouldPrintRawValueis set totrueon aScalar\Float_node, the pretty printer emits the node'srawValueattribute directly instead of normalizing the representation. This allows preserving numeric separators (e.g.1_000.5) and custom representations (e.g. scientific notation like2.4578e12).Changes
lib/PhpParser/PrettyPrinter/Standard.php: CheckshouldPrintRawValueinpScalar_Float()and returnrawValueiftrue.doc/component/Pretty_printing.markdown: Update documentation to mention thatshouldPrintRawValueandrawValueapply to bothScalar\Int_andScalar\Float_.test/PhpParser/PrettyPrinterTest.php:Scalar\Float_with numeric separators, scientific notation, and whenshouldPrintRawValueisfalse.testPrintCustomRawValuewithtestso PHPUnit runs the data provider cases.Verification
All 1,948 tests and 2,817 assertions pass cleanly with PHPUnit.