Repository navigation
Reject malformed Unicode escape sequences - #1176
Merged
Merged
Conversation
nikic
reviewed
Oct 4, 2026
| <?php | ||
| "\u{41"; | ||
| ----- | ||
| Invalid UTF-8 codepoint escape sequence on line 2 |
Owner
There was a problem hiding this comment.
Probably worth testing "\u{" as well, as the minimal invalid sequence?
On the other hand, I'd drop the tests with variables below -- at least it's not obvious to me what extra coverage they are adding.
Contributor
Author
There was a problem hiding this comment.
Thank you. Added a test for \u{ and removed the cases with variables as suggested.
ydah
force-pushed
the
fix-invalid-unicode-escapes
branch
from
October 5, 2026 06:15
457d901 to
cbd65c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String_only matches complete hexadecimal Unicode escapes, leaving malformed sequences as literal text instead of reporting an error:Also match the
\u{prefix and reject it when no complete hexadecimal escape was captured. This catches invalid digits, empty escapes, and missing closing braces.