Fix crash in HomeRootView by injecting the existing SettingsSearchHighlight instance - #1483
Open
premnirmal wants to merge 1 commit into
Open
Fix crash in HomeRootView by injecting the existing SettingsSearchHighlight instance#1483premnirmal wants to merge 1 commit into
premnirmal wants to merge 1 commit into
Conversation
…ngsSearchHighlight instance into the Home-screen CGM configuration sheet. Nightscout’s Upload and Fetch views now inherit their required environment dependency.
premnirmal
requested review from
AndreasStokholm,
MikePlante1,
Sjoerd-Bo3,
bjornoleh,
dnzxy,
kingst,
marionbarker,
marv-out and
t1dude
as code owners
September 8, 2026 21:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NightscoutUploadViewandNightscoutFetchViewrequire aSettingsSearchHighlightenvironment object that is missing when Nightscout configuration is opened from the Home-screen CGM sheet.Cause of the crash is 5cb78b6 which added
.settingsHighlightScroll()to these two views..settingsHighlightScroll()@Environment(SettingsSearchHighlight.self)NavigationStackSettingsSearchHighlightfound” failureSo we can inject the existing settings-highlight environment into the Home CGM sheet so the Nightscout child routes inherit it, without changing the working
Settingsnavigation path.PR fixes the crash in
HomeRootView.swiftby injecting the existingSettingsSearchHighlightinstance into the Home-screen CGM configuration sheet. Nightscout’s Upload and Fetch views now inherit their required environment dependency.Fixes #1480
Test steps: