Plot glucose on the top chart layer so carbs and boluses no longer hide it - #1470
Merged
Conversation
trioneer-dev
requested review from
AndreasStokholm,
MikePlante1,
Sjoerd-Bo3,
bjornoleh,
dnzxy,
kingst,
marionbarker,
marv-out and
t1dude
as code owners
September 5, 2026 22:13
trioneer-dev
force-pushed
the
fix/1451-glucose-on-top
branch
from
September 5, 2026 22:14
bca567d to
abc2222
Compare
t1dude
approved these changes
Sep 7, 2026
t1dude
left a comment
t1dude
left a comment
Contributor
There was a problem hiding this comment.
Tested in simulator as I don't log carbs. LGTM.
MikePlante1
approved these changes
Sep 7, 2026
MikePlante1
left a comment
MikePlante1
left a comment
Contributor
There was a problem hiding this comment.
Code and simulator test look good.
I added some l18n missed from #1375
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self explanatory.
Fixes #1451.