Enter remote meals without a note - #1469
Merged
Merged
Conversation
The carb note is uploaded to Nightscout as foodType, which the chart prints as text next to the carb entry.
bjorkert
requested review from
AndreasStokholm,
MikePlante1,
Sjoerd-Bo3,
bjornoleh,
dnzxy,
kingst,
marionbarker,
marv-out and
t1dude
as code owners
September 4, 2026 20:00
t1dude
approved these changes
Sep 7, 2026
t1dude
left a comment
t1dude
left a comment
Contributor
There was a problem hiding this comment.
Tested in simulator + NS as I don't log carbs.
LGTM.
Contributor
|
Changing the message to something shorter vs. no longer reporting the message seems like a good compromise, otherwise we just drop the carb announcement source (for caregivers) entirely. |
Member
Author
|
The message is now replaced with a 📡 - satellite antenna as a symbol for remote command. |
dnzxy
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carbs entered from a remote meal command get the note "Remote meal command". Trio uploads the carb note in both notes and foodType, and Nightscout prints foodType as text next to the carb entry on the chart, so every remotely entered meal ends up labeled on the graph.
This drops the note, so remote meals render like any other carb entry.