Repository navigation
fix: small audit follow-ups across 7tv, youtube autocomplete, emote modal and hover effects - #8259
Merged
Merged
Conversation
…odal and hover effects Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four small fixes from an audit of 7.7.25 to master, none of them worth a PR each:
updatedandpulledloops inchannel-emotes.jsusedreturnwhere their sibling usescontinue, so one emote BetterTTV didn't know about aborted the rest of that event, including every pull after it.updateFocusListeneradded a new bound focus listener without removing the previous one, so each reload while dirty stacked another. Now mirrors the Twitch version: remove first, then add if still needed.{}, whichfetchAvailabilitythen treated as a cache hit for the rest of the session. The merge now treats a sentinel in the cache as empty, so repeated failures stay retryable..reducedMotionrules now cover.wave,.bounceand.fliptoo.Verification: reasoned from the code, lint and build pass. The CSS is specificity-checked against the hover rules it overrides but not exercised live.
🤖 Generated with Claude Code