Skip to content

fix: Log orchestrator cleanup failures instead of empty catch #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VedantMadane wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Log orchestrator cleanup failures instead of empty catch #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/lib/orchestrator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -910,7 +910,9 @@ If your work needs human review before it can proceed: mc_report(status: "needs_
await killWindow(session, window);
}
}
} catch {}
} catch (err) {
console.warn("[orchestrator] cleanup step failed:", err);
}

if (worktreePath) {
await removeWorktree(worktreePath, true).catch(() => {});
Expand Down Expand Up @@ -1100,7 +1102,9 @@ If your work needs human review before it can proceed: mc_report(status: "needs_
await killWindow(session, window);
}
}
} catch {}
} catch (err) {
console.warn("[orchestrator] cleanup step failed:", err);
}

throw new Error(
`Failed to relaunch job "${jobName}" for correction: ${error instanceof Error ? error.message : String(error)}`,
Expand Down Expand Up @@ -1187,7 +1191,9 @@ If your work needs human review before it can proceed: mc_report(status: "needs_
status: 'stopped',
completedAt: new Date().toISOString(),
});
} catch {}
} catch (err) {
console.warn("[orchestrator] cleanup step failed:", err);
}
}

await deleteIntegrationBranch(plan.id);
Expand Down Expand Up @@ -1280,8 +1286,9 @@ If your work needs human review before it can proceed: mc_report(status: "needs_
});
newJob.port = sourceJob.port;
newJob.launchSessionID = sourceJob.launchSessionID;
} catch {
}
} catch (err) {
console.warn("[orchestrator] operation failed:", err);
}
}
}

Expand Down