feat(relay): add protocol v4 direct identity - #78
Merged
Conversation
nicodes
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes nicodes/ormos-be#546
Defines protocol v4 direct-system terminal/proxy identity while preserving v0-v3 behavior. V4 binds system ID, terminal record ID, exact generation, cwd, action fence, and expiry; labels and project-composite session identity are rejected.
Risk: high — public wire/security contract.
Team No Review: review and approval are intentionally skipped per workstream dispatch. Merge is gated on exact-head CI.
Verification (Go 1.25.13):
go vet ./...;go test -race -count=1 ./...;govulncheck ./...; supported/unsupported platform-selection builds.Deliberate gate failures:
go test ./relay -run TestV4DirectSystemIdentityAndTerminalBinding -count=1failed withv4 terminal for another authenticated system was accepted.go test ./internal/system -run TestTerminalV4UsesDirectSystemRecordGenerationIdentity -count=1failed withfresh v4 admission ignored the authoritative exact generation.Both breaks were reverted and the exact head is green locally.