Skip to content

Refactor per-dimension runtime ownership - #5

Merged
nico2525nn merged 3 commits into
mainfrom
codex/goal-dimension-runtime
Sep 26, 2026
Merged

nico2525nn merged 3 commits into
mainfrom
codex/goal-dimension-runtime

Conversation

@nico2525nn

@nico2525nn nico2525nn commented Sep 26, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Group each dimension's world, block entities, light/fluid/redstone/block-tick services, persistence, and local dispenser/detector-rail state in GameServer::DimensionRuntime.
  • Route dimension-local state through the same canonical 0/-1/1 runtime selector and preserve Overworld/Nether/End iteration order.
  • Update the public architecture overview and internal state/development references without changing the compatibility matrix.

Verification

  • Timeout-wrapped cmake build of build-dimension-runtime: PASS; final incremental invocation reported no work to do.
  • Full non-nightly, non-package CTest: 55/55 PASS in 530.73s on source commit c56c4f0, before the documentation-only commit b092238.
  • After the documentation update, jvm_contract_audit, quality_audit, and tautology_lint: 3/3 PASS.
  • git diff --check: PASS. Post-suite process check found no remaining cppfm server process.

Review and limitations

  • Two independent reviews of the final PR head found no additional actionable issues. Both verified the canonical 0/-1/1 selection, dimension iteration order, and accuracy of the documentation.
  • This is an ownership step, not a completed lifecycle component: service construction and callback wiring remain in GameServer::init(), and service pointers are nullable before initialization.
  • No gameplay behavior, MISSING status, or compatibility claim is promoted. Mineflayer testing remains deferred until the broader code-quality refactor gate is met.
  • GitHub Actions must pass on this exact PR head before merge.

@nico2525nn
nico2525nn merged commit 4756a5b into main Sep 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant