Skip to content

test: stabilize live regression fixtures - #3

Merged
nico2525nn merged 4 commits into
mainfrom
codex/fix-goal-live-remaining
Sep 23, 2026
Merged

nico2525nn merged 4 commits into
mainfrom
codex/fix-goal-live-remaining

Conversation

@nico2525nn

@nico2525nn nico2525nn commented Sep 23, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Make the live world-border fixture teleport before shrinking the border so the player cannot die before the command feedback check.
  • Remove smoke80’s per-test 450-second timeout so it follows the workflow-wide CTest timeout instead of overriding --timeout 600.
  • Reduce the smoke test randomTickSpeed from 100 to 10 (vanilla default is 3), retaining the real 16×16 crop-growth assertion without turning the ordinary regression into a world-wide CPU stress test.
  • Stabilize plan43: identify summoned horses using a pre-summon entity-ID high-water mark, and wait for the initial chunk batch before W-02 interaction/attack cases.
  • Record the observed failures and evidence in the current-state handoff.

Validation

  • Exact current PR head passed Actions run 35891999280 in 24m10s, including configure/build, static checks, deterministic focused gates, and full non-nightly CTest (55 tests).
  • After the W-02 startup barrier, plan43 passed 10 consecutive local launches (260.95s); after the final setup-failure guard was added, the rebuilt target passed again (1/1, 26.03s).
  • Local non-nightly CTest before the latest startup-barrier-only change: 55/55 passed (524.28s).
  • smoke80 isolated run: 225/225 passed (177.88s); also passed in the complete local run (179.03s).
  • goal_live_remaining repeated 5 times: 5/5 passed (263.24s); also passed in the complete local run.
  • git diff --check passed; no orphan cppfm process remained after local tests.

Context

Follow-up to merged PR #1. The first follow-up Actions run exposed a TIMEOUT 450 override despite workflow --timeout 600; removing the target override restored the shared CI limit. A later run exposed one plan43 window assertion, fixed by filtering out stale pre-summon entity IDs. Actions run 35886973563 then passed all but one test: plan43 missed W-02 atk0 lands (HurtAnimation eid). The fixture now waits for ChunkBatchFinished before W-02 work; this is test-readiness hardening, not a production combat change or proof of a server-side cause. The current PR head now passes the required Actions gate.

@nico2525nn nico2525nn changed the title test: stabilize world border live fixture test: stabilize live regression fixtures Sep 23, 2026
@nico2525nn
nico2525nn merged commit f840324 into main Sep 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant