Repository navigation
test: stabilize live regression fixtures - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--timeout 600.plan43: identify summoned horses using a pre-summon entity-ID high-water mark, and wait for the initial chunk batch before W-02 interaction/attack cases.Validation
plan43passed 10 consecutive local launches (260.95s); after the final setup-failure guard was added, the rebuilt target passed again (1/1, 26.03s).goal_live_remainingrepeated 5 times: 5/5 passed (263.24s); also passed in the complete local run.git diff --checkpassed; no orphancppfmprocess remained after local tests.Context
Follow-up to merged PR #1. The first follow-up Actions run exposed a
TIMEOUT 450override despite workflow--timeout 600; removing the target override restored the shared CI limit. A later run exposed oneplan43window assertion, fixed by filtering out stale pre-summon entity IDs. Actions run 35886973563 then passed all but one test:plan43missedW-02 atk0 lands (HurtAnimation eid). The fixture now waits forChunkBatchFinishedbefore W-02 work; this is test-readiness hardening, not a production combat change or proof of a server-side cause. The current PR head now passes the required Actions gate.