Systemd service improvements - #332
Merged
osmith42 merged 4 commits intoAug 17, 2026
Merged
Conversation
Takuto88
approved these changes
Aug 16, 2026
Takuto88
left a comment
Takuto88
left a comment
Collaborator
There was a problem hiding this comment.
The only thing I would personally change is the "optional" on the diameter service. But thats so minor so I don't mind if this stays as is. LGTM 👍
Add comments to make the purpose of each service easier to understand, and which services are optional and legacy, and for which reasons.
Add Requires=, After= for the systemd services to ensure redis-server is started first, then the HSS service and then other services that talk to the HSS service via redis.
Fixes: 20d0b8a ("debian: initial")
osmith42
force-pushed
the
systemd-service-improvements
branch
from
August 17, 2026 07:44
25d63a9 to
0bcba94
Compare
Collaborator
Author
|
Did minor tweaks to the comments (diameter not marked as optional as suggested, linked to the new issue about geored). Merging now, thanks for all the reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits for details.