Improve logging - #328
Merged
Merged
Conversation
Takuto88
requested changes
Aug 11, 2026
Takuto88
left a comment
Takuto88
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this - I've just two minor things for this one.
Add a comment explaining that the logfiles section gets ignored unless the logService job gets started (which we don't in the docker compose and debian packaging setups).
The pyhss log service is not running in docker compose, so the pyhss_logs volume stays empty. Remove it, so users won't assume that something should get written there.
Introduce a new environment variable PYHSS_LOG_STDOUT_NO_TIMESTAMP, and set it in all systemd services. In the logging code, do not print a timestamp if it is set. This fixes having a redundant timestamp in journalctl: Aug 11 11:56:53 hostname pyhss_gsup[146051]: [08/11/2026 11:56:53] [INFO] GSUP server started on 127.0.0.1:4222 I considered making this configurable via config.yaml instead of the environment variable. But I think the env var solution is better as it allows to set this only in the systemd service files, so we still have the timestamps with the default config when the services are started in another way (e.g. via docker).
osmith42
force-pushed
the
improve-logging
branch
from
August 12, 2026 11:32
dcf4e1f to
536ec01
Compare
Takuto88
approved these changes
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits for details.