Drop deprecated vulnerability_alerts from ignore_changes - #13
Merged
Conversation
The only remaining reference to the deprecated github_repository.vulnerability_alerts argument was ignore_changes = [vulnerability_alerts], which surfaced its deprecation warning. Dependabot alerts are managed by the dedicated github_repository_vulnerability_alerts resource; tofu plan confirms removing the reference introduces no vulnerability_alerts diff on any managed repo.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
github_repository.vulnerability_alertsargument is deprecated; Dependabot alerts are already managed by the dedicatedgithub_repository_vulnerability_alertsresource. The only lingering reference to the deprecated argument wasignore_changes = [vulnerability_alerts]ongithub_repository.managed, which is what surfaced the deprecation warning at plan time.ignore_changesreference (thelifecycleblock keepsprevent_destroy = true).tofu plan: novulnerability_alertsdiff appears on any of the 10 managed repos — the deprecated attribute reads as computed, so there's no risk of Terraform disabling alerts.