Skip to content

Fixing LESS, GREATER and IMPLIES operator, outdated typing.io imports and pastification of negative numbers#207

Open
tederer wants to merge 7 commits into
nickovic:masterfrom
tederer:bugFixing
Open

Fixing LESS, GREATER and IMPLIES operator, outdated typing.io imports and pastification of negative numbers#207
tederer wants to merge 7 commits into
nickovic:masterfrom
tederer:bugFixing

Conversation

@tederer

@tederer tederer commented Jun 29, 2026

Copy link
Copy Markdown
  • Set version of antlr4 to 4.9 to get the typing fixes. Deleted StlLexer files because they are outdated and no grammar file (.g4) exists to build them with 4.9.
  • Fixed typing import statements because typing.io is deprecated and removed since Python 3.13.
  • Changed LESS and GREATER operator to return -sys.float_info.min when arguments are identical.
  • Changed IMPLIES operator to use sys.float_info.max for the left argument when it is zero. This prevents implications that are always true, even when they should not be. Added some tests as well to document the original problem.
  • Fixed pastification result when specification/rule contains a negative integer or decimal. Before this fix rules like "signal1 >= -3" or "signal1 >= -3.0" resulted in losing the sign of the "3"-literal.

Thomas Ederer added 7 commits June 24, 2026 14:22
…rgument when it is zero. This prevents implications that are always true, even when they should not be.
…ent when it is zero. This prevents implications that are always true, even when they should not be. Added some tests as well to document the original problem.
…r files because they are outdated and no grammar file (.g4) exists to build them with 4.9.
…e integer or decimal. Before this fix rules like "signal1 >= -3" or "signal1 >= -3.0" resulted in losing the sign of the "3"-literal.
@tederer tederer changed the title Bug fixing Fixing LESS, GREATER and IMPLIES operator, outdated typing.io imports and pastification of negative numbers Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant