Fix TextIO import error#205
Open
qthibeault wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using Python versions >= 3.12, importing RTAMT produces the following error:
The
typing.iomodule was deprecated in Python 3.8 and was scheduled for removal in 3.12, and the types were moved into the basetypingmodule as of Python 3.6. The current usage oftyping.ioin some RTAMT modules means that newer versions of Python are not supported.This fix adds a guard that selects the correct import for the
TextIOtype depending on the version reported bysys.version_info. This approach was chosen rather than just fixing the import to maximize backward compatibility, since the library currently indicates that it supports Python versions earlier than 3.6.