Fix build CI by downgrading zod and adding reactCompilerPreset#53
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAligns runtime and build tooling to work with React compiler by downgrading zod to v3 across apps, slightly adjusting Vite and @vitejs/plugin-react versions, updating the Convex env schema to the zod v3 API, and regenerating the Bun lockfile. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (5)
WalkthroughThis PR downgrades Zod to version ^3.24.2 across the backend and web packages and updates the CLERK_JWT_ISSUER_DOMAIN schema to explicitly validate the input as a string before URL parsing. Supporting dependencies and the Nix lock file are updated to match. ChangesZod Downgrade and Dependency Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since Zod is being downgraded from v4 to v3 across packages, double‑check for any other v4‑only APIs or behaviors (e.g., schema helpers or error shapes) that might now break at runtime and consider adding explicit type guards where assumptions changed.
- In
convex/env.ts, theCLERK_JWT_ISSUER_DOMAINschema now explicitly usesz.string().url(); if this is meant to enforce presence and format at startup, consider also validating against empty/whitespace-only strings or documenting that non-URL values will fail at boot rather than later in the request lifecycle.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since Zod is being downgraded from v4 to v3 across packages, double‑check for any other v4‑only APIs or behaviors (e.g., schema helpers or error shapes) that might now break at runtime and consider adding explicit type guards where assumptions changed.
- In `convex/env.ts`, the `CLERK_JWT_ISSUER_DOMAIN` schema now explicitly uses `z.string().url()`; if this is meant to enforce presence and format at startup, consider also validating against empty/whitespace-only strings or documenting that non-URL values will fail at boot rather than later in the request lifecycle.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Actionable comments posted: 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downgrade zod to ^3.24.2, upgrade vite to ^8.0.0, upgrade @vitejs/plugin-react to ^6.0.2, and add @rolldown/plugin-babel to fix build CI and support reactCompilerPreset.
Summary by Sourcery
Adjust dependencies and environment configuration to restore build CI compatibility and support the React compiler preset.
Enhancements:
Build:
Summary by CodeRabbit