Skip to content

Test Build CI#52

Closed
nickcomua wants to merge 5 commits into
mainfrom
test-build-ci
Closed

Test Build CI#52
nickcomua wants to merge 5 commits into
mainfrom
test-build-ci

Conversation

@nickcomua

@nickcomua nickcomua commented May 28, 2026

Copy link
Copy Markdown
Owner

Temporarily enabling docker CI on pull requests to test build

Summary by Sourcery

Enable Docker build workflow on pull requests and update the CRM web and Convex backend tooling to align with newer Vite/React build infrastructure.

New Features:

  • Enable the Docker GitHub Actions workflow to run on pull_request events in addition to main branch pushes.

Bug Fixes:

  • Align zod versions across CRM web and Convex backend to a common 3.x release to maintain compatibility with existing validation code.

Enhancements:

  • Upgrade the CRM chat web app toolchain to Vite 8 and the latest React plugin, integrating the React compiler via the Rolldown Babel plugin.
  • Refresh the Bun Nix lockfiles for the CRM web and Convex backend services to capture updated frontend and build dependencies, including rolldown and lightningcss versions.
  • Adjust Convex backend environment schema to validate the Clerk issuer domain as a string URL before normalization.

Build:

  • Update Bun/Nix package manifests to add rolldown-related bindings and newer build-time libraries required by the updated Vite/React toolchain.

@sourcery-ai

sourcery-ai Bot commented May 28, 2026

Copy link
Copy Markdown

Reviewer's Guide

Enables the Docker GitHub Actions workflow to run on pull requests and updates the crm-chat-web toolchain (Vite/React/rolldown/lightningcss, etc.) along with dependency alignment changes (notably downgrading zod to v3 in both frontend and backend) and a minor env validation fix.

Flow diagram for updated Vite build toolchain with React compiler

flowchart LR
  subgraph ViteConfig
    direction LR
    TanstackRouterPlugin
    ReactPlugin
    RolldownBabelPlugin
    TailwindcssPlugin
  end

  SourceFiles -->|imported by| ViteConfig

  TanstackRouterPlugin --> ViteBuild
  ReactPlugin --> ViteBuild
  RolldownBabelPlugin -->|presets: reactCompilerPreset| ViteBuild
  TailwindcssPlugin --> ViteBuild

  ViteBuild --> BundledAssets
Loading

File-Level Changes

Change Details Files
Update crm-chat-web build toolchain to newer Vite/React plugin stack with rolldown Babel integration and corresponding dependency versions in Nix and package.json.
  • Upgrade Vite from 7.x to 8.x and @vitejs/plugin-react from 5.x to 6.x in package.json and bun.nix.
  • Introduce @rolldown/plugin-babel, configure it in vite.config.ts with reactCompilerPreset(), and type-cast it as a Vite PluginOption.
  • Remove direct React compiler babel plugin wiring from the react plugin config and rely on rolldown/babel instead.
  • Add/update rolldown and platform-specific binding/lightningcss/emnapi/napi runtime packages in bun.nix, and remove unused Babel plugin and types entries that are no longer required.
bins/crm-chat-web/vite.config.ts
bins/crm-chat-web/package.json
bins/crm-chat-web/bun.nix
bins/crm-chat-web/bun.lock
Align zod versions across crm-chat-web and convex-backend to v3 and adjust backend environment validation accordingly.
  • Downgrade zod dependency from ^4.x to ^3.24.2 in crm-chat-web and convex-backend package.json files.
  • Change zod Nix pin in convex-backend bun.nix from zod@4.3.6 to zod@3.25.76.
  • Update env schema in convex-backend to use z.string().url() before transforming the CLERK_JWT_ISSUER_DOMAIN value to strip trailing slashes.
bins/crm-chat-web/package.json
bins/convex-backend/package.json
bins/convex-backend/bun.nix
bins/convex-backend/convex/env.ts
bins/convex-backend/bun.lock
Enable Docker GitHub Actions workflow to run on pull requests in addition to pushes to main.
  • Add pull_request to the triggers for the docker GitHub Actions workflow so Docker builds run on PRs as well as on main branch pushes.
.github/workflows/docker.yml
Minor Nix expression style tweaks for bun.nix files.
  • Adjust bun.nix function return formatting to put the attribute set on a new line after the parameter list in both crm-chat-web and convex-backend.
bins/crm-chat-web/bun.nix
bins/convex-backend/bun.nix

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@nickcomua, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 14 minutes and 50 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e631860b-69f0-46cd-a6a6-68dd5308d8ab

📥 Commits

Reviewing files that changed from the base of the PR and between 8d5ad6e and c139b36.

⛔ Files ignored due to path filters (2)
  • bins/convex-backend/bun.lock is excluded by !**/*.lock
  • bins/crm-chat-web/bun.lock is excluded by !**/*.lock
📒 Files selected for processing (6)
  • bins/convex-backend/bun.nix
  • bins/convex-backend/convex/env.ts
  • bins/convex-backend/package.json
  • bins/crm-chat-web/bun.nix
  • bins/crm-chat-web/package.json
  • bins/crm-chat-web/vite.config.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test-build-ci

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The bun.nix updates introduce multiple versions of several packages (e.g. rolldown and many @rolldown/binding-* entries for both 1.0.2 and 1.0.3); if older versions are no longer required by the lockfile, pruning them would reduce closure size and keep dependencies clearer.
  • This PR both enables Docker CI on pull requests and makes significant tooling/dependency changes (Vite/react plugin, zod downgrade, rolldown adoption); consider splitting CI configuration from dependency/tooling updates so each change is easier to reason about and revert if needed.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The bun.nix updates introduce multiple versions of several packages (e.g. `rolldown` and many `@rolldown/binding-*` entries for both `1.0.2` and `1.0.3`); if older versions are no longer required by the lockfile, pruning them would reduce closure size and keep dependencies clearer.
- This PR both enables Docker CI on pull requests and makes significant tooling/dependency changes (Vite/react plugin, zod downgrade, rolldown adoption); consider splitting CI configuration from dependency/tooling updates so each change is easier to reason about and revert if needed.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@nickcomua nickcomua closed this May 28, 2026
@nickcomua
nickcomua deleted the test-build-ci branch May 28, 2026 10:37
@nickcomua
nickcomua restored the test-build-ci branch May 28, 2026 10:46
@nickcomua nickcomua reopened this May 28, 2026

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@nickcomua nickcomua closed this May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant