ci: harden CI workflow and add ESLint - #16
Merged
Merged
Conversation
- Run CI across Node 20, 22, and 24 via a build matrix - Add concurrency group to cancel superseded runs on the same ref - Restrict GITHUB_TOKEN to contents:read (least privilege) - Add ESLint (flat config + typescript-eslint) with a lint step - Fix the one issue the linter surfaced: drop an unused Platform import
ni5arga
force-pushed
the
ci/harden-and-eslint
branch
from
June 5, 2026 08:50
739a0d9 to
2549ed7
Compare
Node's test runner only supports glob patterns from Node 21+, so the quoted src/**/*.test.ts glob matched nothing on the Node 20 matrix leg. Expand the file list with find instead, which works on all versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Hardens the CI workflow and adds linting.
CI workflow (
.github/workflows/ci.yml)fail-fast: falseso one version failing doesn't mask the others). Previously only Node 22.permissions: contents: readinstead of the broad defaultGITHUB_TOKEN.npm run lintstep in the pipeline.ESLint
eslint+typescript-eslint(flat config ineslint.config.js), with alintscript._.Drive-by fix
Platformimport insrc/sources/common.ts— removed.Verification
All steps pass locally (lint, format:check, tsc --noEmit, 25 tests, build).
🤖 Generated with Claude Code