Migrate to Jetpack Compose - #57
Closed
nhoxbypass wants to merge 3 commits into
Closed
Conversation
- Replace `@drawable/logo_711_50` with `@drawable/logo_711_red` in `fragment_search.xml`.
- Move store data JSON files (711, circle_k, familymart, shopngo, bsmart, and ministop) from the root `stores_data/` directory to `app/src/mock/assets/stores_data/`.
- Update `FakeFirebaseStoreApiHelper` to load store data from JSON files in the `assets/stores_data` directory instead of using hardcoded helper methods. - Introduce `loadStoresFromAssets` using `Gson` to parse store information for multiple brands (Circle K, MiniStop, FamilyMart, etc.). - Update `RepositoryModule` to provide `@ApplicationContext` to `FakeFirebaseStoreApiHelper` to facilitate asset access. - Refactor `insertOrUpdateComment` in the mock helper to use Kotlin's `getOrPut` for cleaner logic.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #57 +/- ##
==========================================
Coverage 17.81% 17.81%
Complexity 195 195
==========================================
Files 94 94
Lines 2458 2458
Branches 222 222
==========================================
Hits 438 438
Misses 2002 2002
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.