Revamp Main tab - #55
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #55 +/- ##
=============================================
+ Coverage 17.31% 17.86% +0.55%
Complexity 196 196
=============================================
Files 97 94 -3
Lines 2536 2457 -79
Branches 223 222 -1
=============================================
Hits 439 439
+ Misses 2080 2001 -79
Partials 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nhoxbypass
force-pushed
the
feature/revamp_main_tab
branch
from
April 18, 2026 17:25
34a7f10 to
4246f0f
Compare
- Add `.agents/rules/android-architecture.md` to enforce Clean Architecture and ViewModel independence from the Android framework. - Add `.agents/rules/android-tech-stack.md` to define the preferred stack, including Jetpack Compose, Kotlin Coroutines, Hilt, and Retrofit. - Add `.agents/rules/android-testing-quality.md` to require unit tests for business logic and mandate the use of string resources over hardcoded strings.
nhoxbypass
force-pushed
the
feature/revamp_main_tab
branch
from
April 19, 2026 04:33
17aef4a to
025cb16
Compare
- Delete `MainRecentlyFragment`, `MainRecentlyViewModel`, and `RecentlyStoreAdapter`. - Remove corresponding layouts `fragment_main_recently.xml` and `item_recently_location.xml`. - Update `MainPagerAdapter` to reduce page count from 3 to 2, removing the "Recently" tab. - Adjust `offscreenPageLimit` in `MainFragment` to reflect the reduced number of tabs.
- Add "Favourite" item to the navigation drawer menu. - Update `MainViewModel` and `MainActivity` to handle navigation to the Favourite screen. - Remove "Favourite" tab from `MainPagerAdapter`, reducing the main pager to a single "Map" tab. - Implement `showFavouriteView` in `MainActivity` to display `MainFavouriteFragment` as a separate fragment.
…ault view - Remove `MainFragment`, `MainPagerAdapter`, and their associated layout `fragment_main.xml`. - Update `MainActivity` to host `MainMapFragment` directly in the fragment placeholder. - Remove top margin from `map_placeholder` in `fragment_main_map.xml`.
nhoxbypass
force-pushed
the
feature/revamp_main_tab
branch
from
April 19, 2026 05:06
025cb16 to
3c08062
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.