Design: ingest Triton model repositories (sonic-models) - #14
Draft
ngpaladi wants to merge 1 commit into
Draft
Conversation
Add a design doc for serving an existing Triton model repository (the sonic-models layout) with minimal hand-editing. Covers the platform -> backend and config.pbtxt -> Contract mappings, version-directory resolution, the concrete gaps present in sonic-models (tensorflow_graphdef, Triton-style python, ensemble, string dtype), three implementation options with a recommended hybrid, a phased plan, and open questions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft design PR — proposal, not implementation — for serving an existing Triton model repository, concretely the
fastmachinelearning/sonic-modelslayout, with minimal hand-editing.Doc:
design/triton-model-repository-ingestion.mdWhat it covers
sonic-modelsconfigs: Tritonplatform→ nereid backend, andconfig.pbtxtfields → the coreContract(incl.TYPE_dtype normalization and batch/dimssemantics).1/,2/dirs underversion_policy.tensorflow_graphdef(nereid's TF is SavedModel-only), Triton-stylepython(model.py/TritonPythonModel),ensemble, andTYPE_STRING/TYPE_BYTES.config.pbtxt→Contractreader + version-aware loading, with an import escape hatch) — plus a phased plan and open questions.Direct (supported) set
onnxruntime_onnx→ onnx ·pytorch_libtorch→ torch ·tensorflow_savedmodel→ tensorflow.The doc is placed under
design/(outsidedocs/), so it isn't part of the published docs site. Open questions at the end are the main things to weigh in on — model selection, device/concurrency source, native-vs-import, and gap-handling granularity.🤖 Generated with Claude Code